Merged
Conversation
sdas-neuraco
added
the
version:minor
Contributor
|
Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking. |
sdas-neuraco
changed the title
ypang-neuraco
approved these changes
Feb 5, 2026
neuracore/importer/core/base.py
Outdated
Comment on lines
113
to
115
| if skip_on_error not in {"episode", "step", "none"}: | ||
| raise ValueError("skip_on_error must be one of: 'episode', 'step', 'none'") | ||
|
|
Contributor
There was a problem hiding this comment.
perhaps "all" instead of "none"? "none" sounds like nothing is skipped.
sdas-neuraco
force-pushed
the
fix-importer-cli-skip-error
branch
2 times, most recently
from
ed197f8 to
df1415c
Compare
sdas-neuraco
force-pushed
the
fix-importer-cli-skip-error
branch
from
70d6ae2 to
5f8c4c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Added step-level skipping logic to RLDS and LeRobot importers; retained episode-level and fail-fast modes with validation in the base class.
Cleaned sample config and docstrings; ensured pre-commit passes (ruff/pydocstyle fixes).
Bugfixes
Items
Related PRs