Skip to content

Fix zodiac deployment action#19

Closed
fangq wants to merge 13 commits intodev_mariofrom
dev_fang
Closed

Fix zodiac deployment action#19
fangq wants to merge 13 commits intodev_mariofrom
dev_fang

Conversation

@fangq
Copy link
Member

@fangq fangq commented Mar 11, 2025

hi @MarSH-Up, I debugged the sftp action and have to do the following to fix the broken action

  1. as you suggested, fork wlixcc/SFTP-Deploy-Action to NeuroJSON org solved the repo error - I have no idea why it triggers this error despite that this action is already in the Github marketplace, maybe because this is a private repo?
  2. I have to regenerated the ssh private key by adding -m pem with ssh-keygen, so that the output is in the pem format (which has a header of BEGIN RSA PRIVATE KEY)
  3. add the public key to authorized_keys file
ssh-keygen -m pem -t rsa -b ... -C "..."
cat id_rsa.pub >> ~/.ssh/authorized_keys

after the above 3 changes, the action now works

although the built webpage can be uploaded to zodiac, but the page is empty, you can take a look, I will create another issue on this (#20)

https://zodiac.coe.neu.edu/dev/dev_fang/

the body of the index.html file shows "You need to enable JavaScript to run this app."

please take a look and merge to your branch. after we fix the empty page problem, feel free to push it to staging.

@fangq
Copy link
Member Author

fangq commented Mar 11, 2025

I removed the "restart server" action - I thought the generated web page are static only, why do we need to restart?

also, I see you were exporting the private key to a file. I feel this could leak the key in the future if we are not careful.

is this restart step really necessary?

@fangq
Copy link
Member Author

fangq commented Mar 13, 2025

patch already included in #22, closing this one

@fangq fangq closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants