Add check for Units table without spike_times#691
Merged
h-mayorquin merged 5 commits intodevfrom Mar 25, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bendichter
approved these changes
Mar 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #691 +/- ##
==========================================
+ Coverage 79.87% 83.06% +3.19%
==========================================
Files 48 48
Lines 1873 1878 +5
==========================================
+ Hits 1496 1560 +64
+ Misses 377 318 -59
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Units table in NWB exists to describe sorted neural units, and spike times are its core data. A Units table without a spike_times column is almost certainly an error or a misuse of the neurodata type (for example, storing cluster labels or quality metrics without the underlying spike data that gives them meaning).
This PR adds
check_units_table_has_spikesatCRITICALimportance to flag this case.