[Bounty] Headless browser module #40#47
Open
dlbears wants to merge 3 commits intoNextDotID:developfrom
Open
Conversation
Member
|
Amazing contribution! Looks like you hard-coded a path into this code (?) |
Member
|
Oh, got it, you've prepared this file in |
nykma
requested changes
Nov 17, 2022
Member
nykma
left a comment
There was a problem hiding this comment.
Good enough. Only some trivial things to mention.
amended - removed generated native configs (only needed for binary generation), updated go wrapper, split script docker into arm and amd versions
Author
New Files/Folders
ResourcesExciting Performance Improvements (specifically for static strategies; fallback/webdriver remain unchanged)6 request batched using static strategy (same as OP) but using native binary 1.04s
|
typo should be cljc not clj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why Babashka (Clojure)?
Design
HTTP API
CLI API (for individual find):
bb src/finder.clj
-url --url string required
-matcher --matcher string required (css/js/regex/xpath expression)
-match-by --match-by string required (choose one ["css" "js" "regex" "xpath" ])
-secret --secret string
-timeout --timeout unit
-strategy --strategy string required (choose one ["fallback" "static" "webdriver"])
CLI API (for server process):
bb src/finder.clj
-server --server true
-port --port uint (default: 8080)
-address --address string (default 0.0.0.0)
Strategies
25%slower compared to static regex/cssPerformance example and demo
HTTP Batching
6 requests using fallback strategy processed in parallel ~4secs
6 requests using static strategy processed in parallel ~3secs
Currently WIP