Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions nextstep-backend/src/tests/rooms_controller.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,12 @@ describe('Rooms Controller', () => {
});

it('should return 400 for invalid user IDs', async () => {
const invalidUserId = "invalidUserId"
const response = await request(app)
.get(`/room/user/invalidUserId`)
.set('Authorization', `Bearer ${initiatorUser.accessToken}`)
.query({ userId: 'invalidUserId' });

expect(response.status).toBe(400);
expect(response.text).toBe(`{"message":"Validation failed","errors":[{"field":"receiverUserId","message":"Invalid user ID","value":"${invalidUserId}"}]}`);
expect(response.text).toBe(`{"message":"Validation failed","errors":[{"field":"receiverUserId","message":"Invalid user ID"}]}`);
});
});
1 change: 0 additions & 1 deletion nextstep-backend/src/types/validation_errors.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export interface ValidationError {
field: string;
message: string;
value: any;
}
6 changes: 2 additions & 4 deletions nextstep-backend/src/utils/handle_error.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,13 @@ export const handleError = (err: any, res: Response) => {
if (isMongoValidationErrors(err)) {
const errors: ValidationError[] = Object.keys(err.errors).map(field => ({
field,
message: err.errors[field].message,
value: err.errors[field].value
message: err.errors[field].message
}));
res.status(400).json({ message: err.message, errors });
} else if (isReqValidationErrors(err)) {
const errors: ValidationError[] = err.errors.map((error: any) => ({
field: error.parm ?? error.path ,
message: error.msg,
value: error.value
message: error.msg
}));
res.status(400).json({ message: err.message, errors });
} else {
Expand Down
Loading