Conversation
Signed-off-by: Tal Jacob <taljacob2@gmail.com>
Signed-off-by: Tal Jacob <taljacob2@gmail.com>
Signed-off-by: Tal Jacob <taljacob2@gmail.com>
… Well Signed-off-by: Tal Jacob <taljacob2@gmail.com>
taljacob2
force-pushed
the
NXD-fix-froala-image-url
branch
from
d249399 to
f4ec214
Compare
Member
Author
|
Rebased on |
Signed-off-by: Tal Jacob <taljacob2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Froala editor image persistence.
When an image is added to the editor, it is tagged with a local blob URL. And it uploaded it like that, then the next time you log in, it tries to display that URL, but because it was temporarily saved locally, it is deleted, so you don't see it.
The previous solution was to kind of make it work "forcefully", meaning only when you do a submit, go through all these blobs and upload the images, then get a real URL for each of them from the server, and then replace all the blobs with their corresponding URLs. But this is not supported by Froala, so it was done manually and it is unstable.
The solution is as they suggest, that as soon as you upload the image to the editor, you immediately upload it, get the real URL, and then immediately replace the blob with the URL.