Fix spawners to recover after island world unload #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix spawner recovery in setups where island worlds are frequently unloaded/reloaded (e.g., SuperiorSkyblock2 + AdvancedSlimePaper/Slime worlds). Previously, spawner runtime objects could remain in memory across world unloads, keeping stale World references and leaving holograms/tasks unable to recover after the world was loaded again.
What changed
On WorldUnloadEvent, spawners in that world are removed from runtime indexes and marked as pending reload.
On WorldLoadEvent, pending spawners for that world are reloaded from file and re-indexed, ensuring holograms and spawner tasks start fresh in the new world context.
Result
No offline production is introduced (spawners remain inactive while the world is unloaded).
When players return and the world loads, spawners and holograms reliably resume.