Skip to content

Conversation

@pento
Copy link

@pento pento commented Mar 28, 2025

The codebase is using dart:js_interop, but it looks like you've accidentally included the js_interop dependency, as well.

This PR removes that unnecessary dependency, bumps the Dart version to 3.3.0 (when dart:js_interop was introduced), and bumps the flutter version to 3.19.0, to match the Dart version.

@Nikoro Nikoro closed this Oct 17, 2025
@Nikoro Nikoro reopened this Oct 17, 2025
@Nikoro Nikoro requested a review from Copilot November 24, 2025 18:10
Copilot finished reviewing on behalf of Nikoro November 24, 2025 18:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unnecessary js_interop package dependency and updates SDK version constraints. The codebase uses dart:js_interop from the Dart SDK (introduced in Dart 3.3.0), making the external js_interop package dependency redundant. The SDK and Flutter version requirements are updated to align with the minimum versions that support the stable dart:js_interop API.

  • Removed the js_interop: ^0.0.1 dependency from pubspec.yaml
  • Updated Dart SDK constraint to ">=3.3.0 <4.0.0" (when dart:js_interop became stable)
  • Updated Flutter version constraint to ">=3.19.0" (matching Dart 3.3.0 release)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pubspec.yaml Removed unnecessary js_interop package dependency, bumped SDK constraints to 3.3.0/3.19.0, and incremented package version to 1.3.0
CHANGELOG.md Added version 1.3.0 entry documenting the dependency removal and SDK version updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Nikoro
Copy link
Owner

Nikoro commented Nov 24, 2025

Thanks for the PR and the effort you put into it! 🙏
I’m going to close this one, because I’ve already implemented a similar change using the following SDK constraints:

sdk: ^3.2.0
flutter: ^3.16.0

The constraints you proposed would also work, but the ones I’ve chosen keep compatibility a bit broader for existing users.

The fix is now available starting from version 1.3.0
Thanks again for your contribution and for helping improve the package! 💙

@Nikoro Nikoro closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants