[cache] BlockAccessor with caching separate from StateAccessor #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrskv
commented
Jun 25, 2025
| Block: block, | ||
| ConfigAccessor: configAccessor, | ||
| StateAccessor: api.accessor, | ||
| BlockAccessor: execution.NewBlockAccessor(32), // todo: use shared accessor |
Contributor
Author
There was a problem hiding this comment.
will be fixed in state accessor PR
dmtrskv
commented
Jun 25, 2025
| func (b *BlockHashByNumberAccessor) Get(tx db.RoTx, shardId types.ShardId, num types.BlockNumber) (common.Hash, error) { | ||
| key := shardAndBlockId{shardId, num} | ||
| // todo: use cache | ||
| // currently, the block can be somehow updated |
Contributor
Author
There was a problem hiding this comment.
This problem is reproduced in #981
Not caching here is no problem for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of usages of state accessor require only blocks, so we can introduce a simpler block accessor.
The state accessor is modified in another PR: #958