feat(libstore/s3-binary-cache-store): implement abortMultipartUpload()
#14376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
lovesegfault
force-pushed
the
nix-s3-abort-multipart
branch
3 times, most recently
from
416b02d to
7c4555e
Compare
|
🎉 All dependencies have been resolved ! |
Implement `abortMultipartUpload()` for cleaning up incomplete multipart uploads on error: - Constructs URL with `?uploadId=ID` query parameter - Issues `DELETE` request to abort the multipart upload
lovesegfault
force-pushed
the
nix-s3-abort-multipart
branch
from
7c4555e to
3915b3a
Compare
Ericson2314
approved these changes
Oct 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
feat(libstore/s3-binary-cache-store): implement `abortMultipartUpload()`
github-merge-queue
bot
closed this pull request by merging all changes
into
NixOS:master
in
dd0d006
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Oct 28, 2025
feat(libstore/s3-binary-cache-store): implement `abortMultipartUpload()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement
abortMultipartUpload()for cleaning up incomplete multipartuploads on error:
?uploadId=IDquery parameterDELETErequest to abort the multipart uploadContext
Part-Of: #14330
Depends-On: #14377
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.