Merged
Conversation
Member
|
This seems like a fine first step to me. It is nice to know which options best match our current style at a minimum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#6721 tried to automatically format the code with clang, but it was closed. There is a similar PR (#7745), but it has been open for almost a year.
In the meantime, reviews in new PRs reference #6721 or #7745, requesting to re-format the PR with
.cland-format. Examples of those are #8699 (comment) and #7735 (comment).I suggest at least adding
.clang-formatto the repository, it would make it easier to find and discover.I'm not proposing a way to enforce or automatically format the code, we can do that in a different PR.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.