Skip to content

python3Packages.awslambdaric: fix build following simplejson upgrade #139694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Sep 28, 2021
Merged

python3Packages.awslambdaric: fix build following simplejson upgrade #139694

SuperSandro2000 merged 1 commit into from
Sep 28, 2021

Conversation

@austinbutler
Copy link
Member

@austinbutler austinbutler commented Sep 28, 2021 •
edited
Loading

Motivation for this change

awslambdaric fails to build following the upgrade to simplejson 3.17.5 in nixpkgs. See aws/aws-lambda-python-runtime-interface-client#58.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 28, 2021
@austinbutler
Copy link
Member Author

austinbutler commented Sep 28, 2021

Result of nixpkgs-review pr 139694 run on x86_64-linux 1

2 packages built:
  • python38Packages.awslambdaric
  • python39Packages.awslambdaric

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 28, 2021
@SuperSandro2000 SuperSandro2000 merged commit f68d740 into NixOS:master Sep 28, 2021
@austinbutler austinbutler deleted the awslambdaric-simplejson-patch branch September 28, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@austinbutler @SuperSandro2000