Skip to content

sgx-sdk: fix build #156208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mic92 merged 1 commit into from
Jan 25, 2022
Merged

sgx-sdk: fix build #156208

Mic92 merged 1 commit into from
Jan 25, 2022

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 22, 2022 •
edited
Loading

Motivation for this change

As mentioned in #150491

Upstream PR: intel/confidential-computing.sgx#784

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

jonringer commented Jan 22, 2022

cc @veehaitch

@ofborg ofborg bot requested review from arcz and sbellem January 22, 2022 21:23
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 22, 2022
veehaitch
veehaitch approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@veehaitch veehaitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙂 just a minor comment

Mic92
Mic92 reviewed Jan 24, 2022
View reviewed changes
@ofborg ofborg bot requested review from sbellem and veehaitch January 24, 2022 23:55
@Mic92 Mic92 merged commit 9ac39c9 into NixOS:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 left review comments

@arcz arcz Awaiting requested review from arcz

@veehaitch veehaitch Awaiting requested review from veehaitch

+1 more reviewer

@sbellem sbellem sbellem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonringer @Mic92 @sbellem @veehaitch