luaPackages.libluv: fix darwin build#167143
Merged
teto merged 1 commit intoNixOS:masterfrom Apr 4, 2022
Merged
Conversation
libluv was recently converted to a pure cmake package and now there's nothing lua related in the build. However an old workaround to force linking against lua on darwin remains. Clean this up.
github-actions
bot
added
the
6.topic: lua
teto
approved these changes
Apr 4, 2022
ofborg
bot
added
10.rebuild-darwin: 11-100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libluv was recently converted to a pure cmake package and now there's
nothing lua related in the build. However an old workaround to force
linking against lua on darwin remains. Clean this up.
Description of changes
Just trying to fix neovim on aarch64-darwin.
cc @teto who recently touched this in #166162 (2e5732b)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes