Open
Conversation
infinisil
commented
Feb 7, 2023
| construct an error message. | ||
|
|
||
| Type: | ||
| assertAll :: (a -> Bool) -> [a] -> (Int -> a -> String) -> Bool |
Member
Author
There was a problem hiding this comment.
Design decisions:
-
Should it be called with named arguments instead? E.g.
# assertAll :: { # condition :: a -> Bool; # list :: [a]; # message :: Int -> a -> String; # } -> Bool assert assertAll { condition = n: n != 2; list = [ 1 3 5 ]; message = i: n: "Index ${toString i}, value ${toString n} failed."; };
RFC 135 also goes in that direction
-
Should the message have access to not only the first, but all elements that don't satisfy the condition? The module system has such a use case:
Lines 765 to 767 in 12053de
How should this look like? Maybe# assertAll :: { # condition :: a -> Bool; # list :: [a]; # message :: [{ index :: Int; value :: a; }] -> String; # } -> Bool assert assertAll { condition = n: n != 2; list = [ 1 2 3 ]; message = failingElements: "Index ${(head failingElements).index}, value ${(head failingElements).value} failed.";
Contributor
There was a problem hiding this comment.
- Yes, and to make it like RFC 135, it should be
assertAll = {success, message}: list: ...- Sounds good. Possibly with an index attached? Needs more thinking and discussion.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Split off from #209099 where this function is useful. It can also be used for #209375
This work is sponsored by Antithesis ✨
Things done