argc: 1.14.0 -> 1.17.0

[sdedovic]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[sdedovic]

I have these changes overlayed for one of my projects and it works.

[sdedovic]

@jonringer can this be merged?

[ShamrockLee]

It would be great to bump to argc 1.17.0. I'm looking forward to its merge!

[ShamrockLee]

argc: 1.15.0 -> 1.17.0

The three suggestions can be added together as a batch and committed using the web interface with the above commit message header. The update builds successfully on my x86_64-linux NixOS laptop.

[sdedovic]

It would be great to bump to argc 1.17.0. I'm looking forward to its merge!

The three suggestions can be added together as a batch and committed using the web interface with the above commit message header. The update builds successfully on my x86_64-linux NixOS laptop.

wow didn't even realize there are two new versions. updated the PR, thanks for the help!

[ShamrockLee]

LGTM code-wise.

I'm unable to run nixpkgs-review on my current setup (a borrowed laptop), but at least it builds on x86_64-linux.

The functionality tests seems to cover under the checkPhase from upstream. If so, a successful native build should guarantee that the result binary functions as expected.

[sdedovic]

It is now on version 1.19

I have lost interest - I have an overlay for my uses and while I wish to contribute, I am discouraged due to very slow review and merge timelines.

[ShamrockLee]

I am discouraged due to the very slow review and merge timelines.

The slow review process is a long-lasting problem for Nixpkgs and is undoubtedly frustrating. The root cause is the vast rate of pull requests popping out and the comparatively small number of committers.

NixOS/rfcs#172 proposes a solution to this problem by allowing bot-based merging when a given number of maintainers approve a PR. This RFC is currently being discussed, as it changes the security model of Nixpkg's review process. You may be interested.