Skip to content

brainflow: Remove with lib#328128

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
Pandapip1:brainflow-remove-with-lib
Jul 18, 2024
Merged

brainflow: Remove with lib#328128
Aleksanaa merged 1 commit intoNixOS:masterfrom
Pandapip1:brainflow-remove-with-lib

Conversation

@Pandapip1
Copy link
Member

Description of changes

Removes a with lib; (#328019 (comment)).

CC @AndersonTorres

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 requested a review from AndersonTorres July 18, 2024 09:38
@Pandapip1 Pandapip1 added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jul 18, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 18, 2024
@JohnRTitor
Copy link
Member

This is a very trivial change and makes sense to run on multiple packages that are still following this structure. CC @Aleksanaa who likes to run these kind of fixes treewide.

This alone should cause 0 rebuilds.

@Aleksanaa Aleksanaa merged commit 22ac105 into NixOS:master Jul 18, 2024
@JohnRTitor
Copy link
Member

Thanks. Perhaps this can be applied treewide, if anyone wants to pick that up.

@philiptaron
Copy link
Contributor

philiptaron commented Jul 26, 2024

I'm making slow progress in #208242. More reviews and merges appreciated! See also https://discourse.nixos.org/t/removing-most-uses-of-top-level-with/41233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants