Skip to content

Support setting devicetree for systemd-boot via bootspec#330195

Closed
Eisfunke wants to merge 2 commits intoNixOS:masterfrom
Eisfunke:devicetree-systemd-boot
Closed

Support setting devicetree for systemd-boot via bootspec#330195
Eisfunke wants to merge 2 commits intoNixOS:masterfrom
Eisfunke:devicetree-systemd-boot

Conversation

@Eisfunke
Copy link
Contributor

Description of changes

This adds support for setting the devicetree when using systemd-boot as bootloader via a bootspec extension.

I'm currently running this successfully on a Raspberry Pi 4B.

Note that I've added the devicetree setting to bootspec as an extension, it might make more sense to add it natively, I'm not sure.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Eisfunke Eisfunke requested a review from JulienMalka as a code owner July 26, 2024 15:19
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 26, 2024
@JulienMalka
Copy link
Member

I think it makes sense to have this as a bootspec extension, it is planned to have it in bootspec V2 anyway. Will do a more complete review asap.

@JulienMalka
Copy link
Member

Related to #319422

@Eisfunke
Copy link
Contributor Author

Related to #319422

Oops. Didn't notice someone already did basically the same thing.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 26, 2024
@JulienMalka
Copy link
Member

#319422 has been merged, closing. Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants