tests.overriding: structure tests as an attribut set#330434
Merged
roberth merged 1 commit intoNixOS:masterfrom Jul 28, 2024
Merged
tests.overriding: structure tests as an attribut set#330434roberth merged 1 commit intoNixOS:masterfrom
roberth merged 1 commit intoNixOS:masterfrom
Conversation
Make individual tests accessible via tests.override.tests.<name>
Contributor
Author
|
Result of 1 package blacklisted:
|
Member
|
@ofborg build tests.overriding |
roberth
approved these changes
Jul 28, 2024
Member
|
Thanks! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR restructures the exposed
passthru.testsoftests.overridingfrom a list to an attribute set, making individual tests accessible by their names.This is extracted from #330010 and implemented with currently available library functions. Whether to add
lib.concatMapStringAttrsSepis still under discussion.Cc: @roberth
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.