nixos/device-tree: support out-of-tree device#403746
nixos/device-tree: support out-of-tree device#403746qbisi wants to merge 5 commits intoNixOS:staging-nextfrom
Conversation
e1a9097 to
464ff72
Compare
|
The PR's base branch is set to staging, but 163 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
|
9e97219 to
00e3bb2
Compare
|
191ee35 to
7db3f76
Compare
|
cc @K900 may i have you attention on this pr. nixpkgs/nixos/modules/hardware/device-tree.nix Lines 92 to 108 in 88983d4 It's also reasonable to keep those *.dtsi file. |
| ''; | ||
| }; | ||
|
|
||
| loadDeviceTree = mkOption { |
There was a problem hiding this comment.
I suggest instead renaming the existing boot.loader.systemd-boot.installDeviceTree to boot.loader.efi.installDeviceTree and reusing that here (as done in the first commit of #439700).
There was a problem hiding this comment.
In fact, this option is more than a expilict declaration of using deviceTree command in grub.cfg.
You see i did not use the option name installDeviceTree as systemd-boot do.
There is case we put /boot in the same disk partition of /nix/store, so there's no need for grub to copy kernel/initrd/dtb to EFI partition.
This pr add support for thouse out-of-tree boards based on expose compileDts.
With some modification of kernel^dev, we can compile the deviceTree of a custom board without patching kernel source.
A test nixosTest.device-tree.{systemd-boot,grub} is added to valid this pr.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.