Skip to content

redis: skip test integration/replication-rdbchannel#422467

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Prince213:push-oltkovwylryp
Jul 5, 2025
Merged

redis: skip test integration/replication-rdbchannel#422467
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Prince213:push-oltkovwylryp

Conversation

@Prince213
Copy link
Member

Related-to: #422352 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@ghost
Copy link

ghost commented Jul 4, 2025

one minute faster than me

@Prince213 Prince213 added the 1.severity: channel blocker Blocks a channel label Jul 4, 2025
@ghost
Copy link

ghost commented Jul 4, 2025

Someone with more knowledge please enlighten me how this is possible when locally it builds and runs just fine.

@nix-owners nix-owners bot requested a review from globin July 4, 2025 17:12
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jul 4, 2025
@wolfgangwalther wolfgangwalther changed the title redis: skip test integration/failover redis: skip test integration/replication-rdbchannel Jul 4, 2025
@wolfgangwalther
Copy link
Contributor

Changed the PR title, please change the commit message accordingly.

@Prince213 Prince213 force-pushed the push-oltkovwylryp branch from 4d36401 to b819ee2 Compare July 4, 2025 19:21
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 4, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 5, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jul 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 422467
Commit: b819ee2317307ff5d483a43f5ac6d36a33fef6fd


x86_64-linux

✅ 3 packages built:
  • discourse
  • discourseAllPlugins
  • redis

x86_64-darwin

✅ 1 package built:
  • redis

aarch64-darwin

✅ 1 package built:
  • redis

I'm a bit confused... is this marked as broken on aarch64-linux now?

Edit: Not marked broken. But the aarch64-linux package doesn't change, so that's why it didn't rebuild... all good.

@wolfgangwalther wolfgangwalther merged commit 8d63459 into NixOS:master Jul 5, 2025
27 of 29 checks passed
@Prince213
Copy link
Member Author

Thanks!

@Prince213 Prince213 deleted the push-oltkovwylryp branch September 21, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants