-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
python3Packages.blacken-docs: 1.19.1 -> 1.20.0 #441634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.blacken-docs: 1.19.1 -> 1.20.0 #441634
Conversation
l0b0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks nbqa
|
|
if blacken-docs is breaking nbqa, it's a blocker. because only nbqa depends on it in the repo. $ rg blacken-docs
pkgs/top-level/python-packages.nix
1966: blacken-docs = callPackage ../development/python-modules/blacken-docs { };
pkgs/top-level/all-packages.nix
2594: blacken-docs = with python3Packages; toPythonApplication blacken-docs;
pkgs/by-name/nb/nbqa/package.nix
35: blacken-docs
115: description = "Run ruff, isort, pyupgrade, mypy, pylint, flake8, black, blacken-docs, and more on Jupyter Notebooks";
pkgs/development/python-modules/blacken-docs/default.nix
11: pname = "blacken-docs";
17: repo = "blacken-docs";
29: homepage = "https://github.com/adamchainz/blacken-docs";
30: changelog = "https://github.com/adamchainz/blacken-docs/blob/${src.rev}/CHANGELOG.rst";
34: mainProgram = "blacken-docs"; |
Yep. Unfortunately I no longer use nbqa/blacken-docs in my current projects, so I'm probably the wrong person to maintain this. Would you be willing to take over, @phanirithvij? |
|
@l0b0 looks like nbqa is broken in master, we can merge this pr. I'll see if I can open a pr fixing the nbqa build. |
|
@NixOS/nixpkgs-merge-bot merge |
|
I opened a fix for nbQA nbQA-dev/nbQA#892. will open a pr fixing it in a while. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python3Packages.blacken-docs is: Run Black on Python code blocks in documentation files
meta.homepage for python3Packages.blacken-docs is: https://github.com/adamchainz/blacken-docs
meta.changelog for python3Packages.blacken-docs is: https://github.com/adamchainz/blacken-docs/blob/refs/tags/1.20.0/CHANGELOG.rst
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from the cache:
(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewCommit:
a6e992f3ac94075ee4a0ec9332fea6535a535c58x86_64-linux❌ 2 packages failed to build:
✅ 4 packages built:
Maintainer pings
cc @l0b0 for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*, you can comment@NixOS/nixpkgs-merge-bot mergeto automatically merge this update using thenixpkgs-merge-bot.Add a 👍 reaction to pull requests you find important.