Skip to content

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python3Packages.blacken-docs is: Run Black on Python code blocks in documentation files

meta.homepage for python3Packages.blacken-docs is: https://github.com/adamchainz/blacken-docs

meta.changelog for python3Packages.blacken-docs is: https://github.com/adamchainz/blacken-docs/blob/refs/tags/1.20.0/CHANGELOG.rst

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.20.0 with grep in /nix/store/zaaj2l5yqdxi72h02l71br5mgyy9zzn9-python3.13-blacken-docs-1.20.0
  • found 1.20.0 in filename of file in /nix/store/zaaj2l5yqdxi72h02l71br5mgyy9zzn9-python3.13-blacken-docs-1.20.0

Rebuild report (if merged into master) (click to expand)
5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

blacken-docs
nbqa
python312Packages.blacken-docs
python313Packages.blacken-docs
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/zaaj2l5yqdxi72h02l71br5mgyy9zzn9-python3.13-blacken-docs-1.20.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python3Packages.blacken-docs https://github.com/r-ryantm/nixpkgs/archive/a6e992f3ac94075ee4a0ec9332fea6535a535c58.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/a6e992f3ac94075ee4a0ec9332fea6535a535c58#python3Packages.blacken-docs

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/zaaj2l5yqdxi72h02l71br5mgyy9zzn9-python3.13-blacken-docs-1.20.0
ls -la /nix/store/zaaj2l5yqdxi72h02l71br5mgyy9zzn9-python3.13-blacken-docs-1.20.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: a6e992f3ac94075ee4a0ec9332fea6535a535c58


x86_64-linux

❌ 2 packages failed to build:
  • nbqa
  • nbqa.dist
✅ 4 packages built:
  • blacken-docs (python313Packages.blacken-docs)
  • blacken-docs.dist (python313Packages.blacken-docs.dist)
  • python312Packages.blacken-docs
  • python312Packages.blacken-docs.dist

Maintainer pings

cc @l0b0 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Sep 10, 2025
@nix-owners nix-owners bot requested a review from l0b0 September 10, 2025 01:18
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks nbqa

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 10, 2025
@phanirithvij
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 441634

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/17634734102


x86_64-linux

❌ 2 packages failed to build:
  • nbqa
  • nbqa.dist
✅ 4 packages built:
  • blacken-docs (python313Packages.blacken-docs)
  • blacken-docs.dist (python313Packages.blacken-docs.dist)
  • python312Packages.blacken-docs
  • python312Packages.blacken-docs.dist

Error logs: `x86_64-linux`
nbqa
            f"{expected_path_2}:cell_1:5:8: F401 [*] `nbqa` imported but unused\n"
        )
>       assert "\n".join(sorted(out.replace("\r\n", "\n").splitlines())) == "\n".join(
            sorted(expected_out.splitlines())
        )
E       AssertionError: assert '' == 'tests/data/n...ed but unused'
E         
E         - tests/data/notebook_for_testing.ipynb:cell_1:1:8: F401 [*] `os` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:3:8: F401 [*] `glob` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:5:8: F401 [*] `nbqa` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:1: E402 Module level import not at top of file
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:20: F401 [*] `random.randint` imported but unused�[90...
E         
E         ...Full output truncated (9 lines hidden), use '-vv' to show

tests/tools/test_ruff_works.py:73: AssertionError
=========================== short test summary info ============================
FAILED tests/tools/test_ruff_works.py::test_ruff_works[/build/source/tests/data/notebook_for_testing.ipynb-/build/source/tests/data/notebook_for_testing_copy.ipynb-/build/source/tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
FAILED tests/tools/test_ruff_works.py::test_ruff_works[tests/data/notebook_for_testing.ipynb-tests/data/notebook_for_testing_copy.ipynb-tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
=========== 2 failed, 99 passed, 3 skipped, 14 deselected in 35.05s ============


aarch64-linux

❌ 2 packages failed to build:
  • nbqa
  • nbqa.dist
✅ 4 packages built:
  • blacken-docs (python313Packages.blacken-docs)
  • blacken-docs.dist (python313Packages.blacken-docs.dist)
  • python312Packages.blacken-docs
  • python312Packages.blacken-docs.dist

Error logs: `aarch64-linux`
nbqa
            f"{expected_path_2}:cell_1:5:8: F401 [*] `nbqa` imported but unused\n"
        )
>       assert "\n".join(sorted(out.replace("\r\n", "\n").splitlines())) == "\n".join(
            sorted(expected_out.splitlines())
        )
E       AssertionError: assert '' == 'tests/data/n...ed but unused'
E         
E         - tests/data/notebook_for_testing.ipynb:cell_1:1:8: F401 [*] `os` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:3:8: F401 [*] `glob` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:5:8: F401 [*] `nbqa` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:1: E402 Module level import not at top of file
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:20: F401 [*] `random.randint` imported but unused�[90...
E         
E         ...Full output truncated (9 lines hidden), use '-vv' to show

tests/tools/test_ruff_works.py:73: AssertionError
=========================== short test summary info ============================
FAILED tests/tools/test_ruff_works.py::test_ruff_works[/build/source/tests/data/notebook_for_testing.ipynb-/build/source/tests/data/notebook_for_testing_copy.ipynb-/build/source/tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
FAILED tests/tools/test_ruff_works.py::test_ruff_works[tests/data/notebook_for_testing.ipynb-tests/data/notebook_for_testing_copy.ipynb-tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
=========== 2 failed, 99 passed, 3 skipped, 14 deselected in 28.32s ============


x86_64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • nbqa
  • nbqa.dist
✅ 4 packages built:
  • blacken-docs (python313Packages.blacken-docs)
  • blacken-docs.dist (python313Packages.blacken-docs.dist)
  • python312Packages.blacken-docs
  • python312Packages.blacken-docs.dist

Error logs: `x86_64-darwin`
nbqa
            f"{expected_path_2}:cell_1:5:8: F401 [*] `nbqa` imported but unused\n"
        )
>       assert "\n".join(sorted(out.replace("\r\n", "\n").splitlines())) == "\n".join(
            sorted(expected_out.splitlines())
        )
E       AssertionError: assert '' == 'tests/data/n...ed but unused'
E         
E         - tests/data/notebook_for_testing.ipynb:cell_1:1:8: F401 [*] `os` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:3:8: F401 [*] `glob` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:5:8: F401 [*] `nbqa` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:1: E402 Module level import not at top of file
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:20: F401 [*] `random.randint` imported but unused�[90...
E         
E         ...Full output truncated (9 lines hidden), use '-vv' to show

tests/tools/test_ruff_works.py:73: AssertionError
=========================== short test summary info ============================
FAILED tests/tools/test_ruff_works.py::test_ruff_works[/nix/build/nix-build-nbqa-1.9.1.drv-4703-4274949840/source/tests/data/notebook_for_testing.ipynb-/nix/build/nix-build-nbqa-1.9.1.drv-4703-4274949840/source/tests/data/notebook_for_testing_copy.ipynb-/nix/build/nix-build-nbqa-1.9.1.drv-4703-4274949840/source/tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
FAILED tests/tools/test_ruff_works.py::test_ruff_works[tests/data/notebook_for_testing.ipynb-tests/data/notebook_for_testing_copy.ipynb-tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
====== 2 failed, 99 passed, 3 skipped, 14 deselected in 84.96s (0:01:24) =======


aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • nbqa
  • nbqa.dist
✅ 4 packages built:
  • blacken-docs (python313Packages.blacken-docs)
  • blacken-docs.dist (python313Packages.blacken-docs.dist)
  • python312Packages.blacken-docs
  • python312Packages.blacken-docs.dist

Error logs: `aarch64-darwin`
nbqa
            f"{expected_path_2}:cell_1:5:8: F401 [*] `nbqa` imported but unused\n"
        )
>       assert "\n".join(sorted(out.replace("\r\n", "\n").splitlines())) == "\n".join(
            sorted(expected_out.splitlines())
        )
E       AssertionError: assert '' == 'tests/data/n...ed but unused'
E         
E         - tests/data/notebook_for_testing.ipynb:cell_1:1:8: F401 [*] `os` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:3:8: F401 [*] `glob` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_1:5:8: F401 [*] `nbqa` imported but unused
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:1: E402 Module level import not at top of file
E         - tests/data/notebook_for_testing.ipynb:cell_4:1:20: F401 [*] `random.randint` imported but unused�[90...
E         
E         ...Full output truncated (9 lines hidden), use '-vv' to show

tests/tools/test_ruff_works.py:73: AssertionError
=========================== short test summary info ============================
FAILED tests/tools/test_ruff_works.py::test_ruff_works[/nix/build/nix-build-nbqa-1.9.1.drv-8435-1165305521/source/tests/data/notebook_for_testing.ipynb-/nix/build/nix-build-nbqa-1.9.1.drv-8435-1165305521/source/tests/data/notebook_for_testing_copy.ipynb-/nix/build/nix-build-nbqa-1.9.1.drv-8435-1165305521/source/tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
FAILED tests/tools/test_ruff_works.py::test_ruff_works[tests/data/notebook_for_testing.ipynb-tests/data/notebook_for_testing_copy.ipynb-tests/data/notebook_starting_with_md.ipynb] - AssertionError: assert '' == 'tests/data/n...ed but unused'
=========== 2 failed, 99 passed, 3 skipped, 14 deselected in 51.36s ============

@phanirithvij
Copy link
Member

if blacken-docs is breaking nbqa, it's a blocker. because only nbqa depends on it in the repo.

$ rg blacken-docs
pkgs/top-level/python-packages.nix
1966:  blacken-docs = callPackage ../development/python-modules/blacken-docs { };

pkgs/top-level/all-packages.nix
2594:  blacken-docs = with python3Packages; toPythonApplication blacken-docs;

pkgs/by-name/nb/nbqa/package.nix
35:        blacken-docs
115:      description = "Run ruff, isort, pyupgrade, mypy, pylint, flake8, black, blacken-docs, and more on Jupyter Notebooks";

pkgs/development/python-modules/blacken-docs/default.nix
11:  pname = "blacken-docs";
17:    repo = "blacken-docs";
29:    homepage = "https://github.com/adamchainz/blacken-docs";
30:    changelog = "https://github.com/adamchainz/blacken-docs/blob/${src.rev}/CHANGELOG.rst";
34:    mainProgram = "blacken-docs";

@l0b0
Copy link
Contributor

l0b0 commented Sep 12, 2025

if blacken-docs is breaking nbqa, it's a blocker. because only nbqa depends on it in the repo.

Yep. Unfortunately I no longer use nbqa/blacken-docs in my current projects, so I'm probably the wrong person to maintain this. Would you be willing to take over, @phanirithvij?

@phanirithvij
Copy link
Member

@l0b0 looks like nbqa is broken in master, we can merge this pr. I'll see if I can open a pr fixing the nbqa build.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 12, 2025
@l0b0
Copy link
Contributor

l0b0 commented Sep 13, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@l0b0 merge not permitted (#305350):
pkgs/development/python-modules/blacken-docs/default.nix is not in pkgs/by-name/

@phanirithvij
Copy link
Member

I opened a fix for nbQA nbQA-dev/nbQA#892. will open a pr fixing it in a while.

@pyrox0 pyrox0 added this pull request to the merge queue Sep 17, 2025
Merged via the queue into NixOS:master with commit 16fe559 Sep 17, 2025
36 of 37 checks passed
@r-ryantm r-ryantm deleted the auto-update/python3Packages.blacken-docs branch September 17, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants