scion: 0.12.0 -> 0.12.0-unstable-2025-10-13 #456277
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nix-owners
bot
requested review from
MatthewCroughan,
OPNA2608,
Prince213,
ethancedwards8,
fricklerhandwerk,
sarcasticadmin and
wegank
This comment was marked as outdated.
This comment was marked as outdated.
eljamm
force-pushed
the
update/scion
branch
4 times, most recently
from
cc6cfbc to
cc66e9c
Compare
Prince213
reviewed
Oct 28, 2025
pkgs/by-name/sc/scion/package.nix
Outdated
| @@ -36,15 +36,28 @@ buildGoModule (finalAttrs: { | |||
| set -e | |||
| ''; | |||
|
|
|||
| preCheck = '' | |||
| # remove tests that require internet access | |||
| find -name net_test.go -exec rm '{}' \; | |||
There was a problem hiding this comment.
How many tests have this name?
There was a problem hiding this comment.
Currently, I think it's only 1 file, but it doesn't hurt to be safe, IMO.
There was a problem hiding this comment.
A bit weird to me as potential future tests may not use the name net_test.go.
Prince213
added
the
8.has: package (update)
|
nixpkgs-ci
bot
removed
the
11.by: package-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest tag is pretty old (from 2024), but upstream is being regularly updated.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.