Skip to content

Conversation

@kyehn
Copy link
Contributor

@kyehn kyehn commented Oct 28, 2025

https://github.com/PaddlePaddle/Paddle/releases/tag/v3.2.0
PaddlePaddle/Paddle@v3.0.0...v3.2.0

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 28, 2025
@nix-owners nix-owners bot requested review from happysalada and natsukium October 28, 2025 00:11
@kyehn
Copy link
Contributor Author

kyehn commented Oct 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 456329
Commit: 9453275efff8532207b51fce3388b8459e619a2e


x86_64-linux

✅ 18 packages built:
  • python312Packages.aistudio-sdk
  • python312Packages.aistudio-sdk.dist
  • python312Packages.bce-python-sdk
  • python312Packages.bce-python-sdk.dist
  • python312Packages.modelscope
  • python312Packages.modelscope.dist
  • python312Packages.paddle2onnx
  • python312Packages.paddle2onnx.dist
  • python312Packages.paddleocr
  • python312Packages.paddleocr.dist
  • python312Packages.paddlepaddle
  • python312Packages.paddlepaddle.dist
  • python312Packages.paddlex
  • python312Packages.paddlex.dist
  • python313Packages.modelscope
  • python313Packages.modelscope.dist
  • python313Packages.paddlepaddle
  • python313Packages.paddlepaddle.dist

aarch64-linux

✅ 14 packages built:
  • python312Packages.aistudio-sdk
  • python312Packages.aistudio-sdk.dist
  • python312Packages.bce-python-sdk
  • python312Packages.bce-python-sdk.dist
  • python312Packages.modelscope
  • python312Packages.modelscope.dist
  • python312Packages.paddlepaddle
  • python312Packages.paddlepaddle.dist
  • python312Packages.paddlex
  • python312Packages.paddlex.dist
  • python313Packages.modelscope
  • python313Packages.modelscope.dist
  • python313Packages.paddlepaddle
  • python313Packages.paddlepaddle.dist

aarch64-darwin

✅ 16 packages built:
  • python312Packages.aistudio-sdk
  • python312Packages.aistudio-sdk.dist
  • python312Packages.bce-python-sdk
  • python312Packages.bce-python-sdk.dist
  • python312Packages.modelscope
  • python312Packages.modelscope.dist
  • python312Packages.paddleocr
  • python312Packages.paddleocr.dist
  • python312Packages.paddlepaddle
  • python312Packages.paddlepaddle.dist
  • python312Packages.paddlex
  • python312Packages.paddlex.dist
  • python313Packages.modelscope
  • python313Packages.modelscope.dist
  • python313Packages.paddlepaddle
  • python313Packages.paddlepaddle.dist

x86_64-darwin

✅ 10 packages built:
  • python312Packages.aistudio-sdk
  • python312Packages.aistudio-sdk.dist
  • python312Packages.bce-python-sdk
  • python312Packages.bce-python-sdk.dist
  • python312Packages.modelscope
  • python312Packages.modelscope.dist
  • python312Packages.paddlex
  • python312Packages.paddlex.dist
  • python313Packages.modelscope
  • python313Packages.modelscope.dist

disabled = pythonAtLeast "3.13";
pyproject = true;

src = fetchPypi {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetching from version control is preferred

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tags are available in this GitHub repository

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an upstream issue.
Also, meta.homepage should point to the repository rather than PyPI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyehn kyehn force-pushed the paddlepaddle branch 4 times, most recently from 2d72cf2 to b8028a5 Compare October 28, 2025 04:00
@kyehn kyehn marked this pull request as draft October 28, 2025 04:13
@kyehn kyehn marked this pull request as ready for review October 28, 2025 04:56
@kyehn
Copy link
Contributor Author

kyehn commented Oct 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 456329 --package pkgsCuda.python313Packages.paddlepaddle --package pkgsCuda.python312Packages.paddlepaddle
Commit: 088e747bc7569e9bb59ffe63fe3a5928bdf2cee6


x86_64-linux

✅ 4 packages built:
  • pkgsCuda.python312Packages.paddlepaddle
  • pkgsCuda.python312Packages.paddlepaddle.dist (pkgsCuda.python312Packages.paddlepaddle.dist.dist)
  • pkgsCuda.python313Packages.paddlepaddle
  • pkgsCuda.python313Packages.paddlepaddle.dist (pkgsCuda.python313Packages.paddlepaddle.dist.dist)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should run tests.

maintainers = with lib.maintainers; [ happysalada ];
platforms = [
"x86_64-linux"
"x86_64-darwin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

astor,
opt-einsum,
typing-extensions,
pip,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip,

Any use of pip should probably be patched out.

hash
platform
;
pname = builtins.replaceStrings [ "-" ] [ "_" ] pname;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pname = builtins.replaceStrings [ "-" ] [ "_" ] pname;
pname = "paddlepaddle";

];

pythonImportsCheck = [ "paddle" ];
pythonImportsCheck = lib.optionals stdenv.hostPlatform.isLinux [ "paddle" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pythonImportsCheck = lib.optionals stdenv.hostPlatform.isLinux [ "paddle" ];
pythonImportsCheck = [ "paddle" ];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants