linuxPackages.morse-driver: init at 1.16.4 #458358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
nixpkgs-ci
bot
added
the
12.first-time contribution
nixpkgs-ci
bot
added
the
8.has: maintainer-list (update)
alyssais
previously requested changes
Nov 4, 2025
Member
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
The patch does not look like something we should be applying for Nixpkgs for a new package. It should go upstream.
govindsi
force-pushed
the
morse-driver
branch
from
d69c22c to
85b080e
Compare
govindsi
force-pushed
the
morse-driver
branch
from
85b080e to
06197c8
Compare
govindsi
changed the title
alyssais
reviewed
Nov 13, 2025
Member
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
Latter two commits should be squashed into the first one per CONTRIBUTING.md.
| (fetchpatch { | ||
| url = "https://github.com/MorseMicro/morse_driver/commit/366772a6801baa37171afbf4ecec103d58f97de5.patch"; | ||
| sha256 = "sha256-DqpPYBeeQXkXvmqvC7ltAwrFRO/rtNv+PZYd3I01H4M="; | ||
| }) |
Member
There was a problem hiding this comment.
Per pkgs/README.md, unmerged GitHub PRs shouldn't be fetched with fetchpatch. Include the patch file in the package directory.
Contributor
Author
There was a problem hiding this comment.
thanks for the review, updated.
govindsi
force-pushed
the
morse-driver
branch
from
06197c8 to
2d91531
Compare
Member
|
Okay, the package looks fine, but the patch is quite big, and the fact that they haven't managed to update to support Linux 6.12 a year after it was released does not fill me with confidence for the future maintainability of this package, so I'll wait for a second opinion on whether this is something we feel we can maintain in Nixpkgs. |
Contributor
Author
Thanks @alyssais for the review comments. Right now I am keeping a downstream derivation and hoping to fetch from upstream Nixpkgs soon. As per Morsemicro, they will get this merged in upcoming release updates. @Ma27 @NeQuissimus and others any feedback, much appreciated. |
Member
|
Member
|
I checked the situation and it seems they work on upstream support and cannot accept this patch for some compliance reason (missing CLA process). Other nix community folks also failed to build this: https://community.morsemicro.com/t/fail-to-compile-morse-driver-for-rv1106-kernel/932/6 So hopefully this mean we can limit this kernel module at some point to old linux kernel versions? Or just drop it at this point? I am willing to accept this patch, if we get also future fixes from @govindsi . |
Member
|
Reviewed the patch and I have one open question for it: https://github.com/MorseMicro/morse_driver/pull/7/files#r2585255598 |
Add the morse Wi-Fi halow driver package version 1.16.4. Signed-off-by: Govind Singh <govind.sk85@gmail.com>
Signed-off-by: Govind Singh <govind.sk85@gmail.com>
govindsi
force-pushed
the
morse-driver
branch
from
e23b970 to
94fc1eb
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
|
Mic92
approved these changes
Dec 5, 2025
Member
There was a problem hiding this comment.
The patch is now very small and given the new very constraint version range, if we actually fall behind updating this, it will just fall out of the nixpkgs automatically because no kernel would support this anymore. I think this is the best outcome as it just creates 4 builds in total (2 per architecture)
Mic92
dismissed
alyssais’s stale review
The patch has been proposed upstream - but upstream doesn't accept patches at the moment. If things go to plan we will longterm see an new upstream kernel module for new kernels instead.
nixpkgs-ci
bot
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the morse Wi-Fi driver package version 1.16.4.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.