Skip to content

writeShellApplication: use lib.concatMapAttrsStringSep #460411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShamrockLee merged 1 commit into from
Nov 10, 2025
Merged

writeShellApplication: use lib.concatMapAttrsStringSep #460411

ShamrockLee merged 1 commit into from
Nov 10, 2025

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Nov 10, 2025 •
edited
Loading

Use lib.concatMapAttrsStringSep provided by PR #330010, decreasing one level of indentation with identical semantics.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 10, 2025
@ShamrockLee ShamrockLee marked this pull request as ready for review November 10, 2025 18:32
@nixpkgs-ci nixpkgs-ci bot requested a review from philiptaron November 10, 2025 18:40
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 10, 2025
@ShamrockLee ShamrockLee added this pull request to the merge queue Nov 10, 2025
Merged via the queue into NixOS:master with commit 6f19429 Nov 10, 2025
30 of 34 checks passed
@ShamrockLee ShamrockLee deleted the write-shell-application-concatMapAttrsStringSep branch November 10, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@philiptaron philiptaron Awaiting requested review from philiptaron

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShamrockLee @drupol