Skip to content

Conversation

@quantenzitrone
Copy link
Contributor

@quantenzitrone quantenzitrone commented Jan 17, 2026

this triggers 1 "rebuild", however this is not really a rebuild

see the commit message for build2 for details

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 17, 2026
@quantenzitrone quantenzitrone force-pushed the move-to-pkgs-by-name-2 branch 15 times, most recently from 39080ca to ae0a858 Compare January 17, 2026 05:45
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 17, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 17, 2026
@quantenzitrone quantenzitrone force-pushed the move-to-pkgs-by-name-2 branch 4 times, most recently from 0d5f516 to a4f2aad Compare January 17, 2026 14:05
@quantenzitrone
Copy link
Contributor Author

2^5 commits should be enough again

this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
This triggers 1 "rebuild", however this is not really a rebuild.
This commit just moves `build2.passthru.bootstrap` to
`build2-bootstrap`, which is seen as a new package.
It is already build since it's a dependency of `build2`.

in conclusion this doesn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
@qweered
Copy link
Contributor

qweered commented Jan 21, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 480855
Commit: 7474a2858c4cc126904b311bf3d2d2babf8c60fd (subsequent changes)
Merge: 03a6ba64f6bdf9178badf740402bd7f24b22f396

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/21192316444


x86_64-linux

✅ 1 package built:
  • build2-bootstrap

aarch64-linux

✅ 1 package built:
  • build2-bootstrap

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • build2-bootstrap

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • build2-bootstrap

Copy link
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 21, 2026
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these, diff looks good.

this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds
this shouldn't create any rebuilds

i removed the libmpeg = mpeg2dec, because mpeg2dec is just an alias for libmpeg
see https://github.com/NixOS/nixpkgs/blob/5d361f1d1d9861315db845a33fa2ac6c77f075ef/pkgs/top-level/all-packages.nix#L7620
this shouldn't create any rebuilds
this shouldn't create any rebuilds
@gepbird gepbird added this pull request to the merge queue Jan 21, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 21, 2026
Merged via the queue into NixOS:master with commit 88d3861 Jan 21, 2026
28 checks passed
@quantenzitrone quantenzitrone deleted the move-to-pkgs-by-name-2 branch January 22, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants