Conversation
It can be source of trouble for some read-only folders (libluv for instance) and slow down install.
ofborg
bot
added
the
6.topic: lua
ofborg
bot
added
10.rebuild-darwin: 101-500
Member
Author
|
nixpkgs-review looks fine, the error being unrelated |
doronbehar
approved these changes
Feb 27, 2020
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 27, 2020
- introduce a default checkPhase for lua (disabled by default) - dont apply patchShebangs on the whole lua package; hopefulyl it doesnt break stuff (cherry picked from commit 7f821b3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 changes:
luarocks 3.X introduced a testing infra. Almost no package support it and I've had issues with the few that have, thus tests default to off. I managed today to find the issues in argparse for instance so I hope to be able to turn the flag on in a future release.
Patchshebangs posed problem when overriding some sources since it tried to write on readonly folders. Also it slows the install as it goes through the folder structure. I am not sure why I put it there in the first place but that looks bad and packages should be responsible for calling it I believe. I am afraid it may create some regressions but I don't have the necessary space to run a nixpkgs-review
When looking at luaPackages.luv: cleanup build #80528, I noticed the lua infra doesn't work well with the cmake based lua packages. This isnot mandatory per se but having a structured attrset instead of a string looks better.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)