Skip to content

nixos-shell: init at 0.1.1 #85673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mic92 merged 1 commit into from
May 24, 2020
Merged

nixos-shell: init at 0.1.1 #85673

Mic92 merged 1 commit into from
May 24, 2020

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 21, 2020 •
edited
Loading

Motivation for this change

Based on popular demand. fixes Mic92/nixos-shell#2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Apr 21, 2020
Closed
@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 21, 2020
@Mic92 Mic92 marked this pull request as draft April 21, 2020 12:22
@Mic92
Copy link
Member Author

Mic92 commented Apr 21, 2020

This still causes infinite recursion. Need to find out why.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 21, 2020
@doronbehar doronbehar mentioned this pull request May 23, 2020
Closed
10 tasks
doronbehar
doronbehar reviewed May 23, 2020
View reviewed changes
@Mic92 Mic92 marked this pull request as ready for review May 24, 2020 07:08
@Mic92 Mic92 merged commit 9df4eba into NixOS:master May 24, 2020
@Mic92 Mic92 deleted the nixos-shell branch May 24, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar left review comments

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add to nixpkgs?

2 participants

@Mic92 @doronbehar