lua.pkgs.pulseaudio: Move from generated to lua-packages.nix #89767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: lua
Member
|
Might also need to remove it from https://github.com/doronbehar/nixpkgs/blob/lua-pulseaudio-fix/maintainers/scripts/luarocks-packages.csv |
Contributor
Author
|
It was never there - #89632 didn't add it to. |
Member
|
Seems to have been added in doronbehar@922de4f. Not sure if the file only contains packages to be generated or it does something different. |
From some reason, the package is not usable if it's built with `buildLuarocksPackage`. Adding `extraVariables` as in `makeFlags` doesn't work. See: NixOS#89632 (comment) Also, remove it from luarocks-packages.csv so hopefully no one will touch it in the future.
doronbehar
force-pushed
the
lua-pulseaudio-fix
branch
from
a01a6ad to
cb9b442
Compare
Contributor
Author
These are files to be generated. If I hadn't done so at doronbehar@922de4f, #89632 wouldn't have added it to the generated set. |
10 tasks
10 tasks
doronbehar
added a commit
to doronbehar/nixpkgs
that referenced
this pull request
Aug 8, 2020
It's not maintained any more by upstream (by @doronbehar) and it doesn't build correctly with `buildLuarocksPackage` (see NixOS#89767).
teto
pushed a commit
that referenced
this pull request
Aug 8, 2020
It's not maintained any more by upstream (by @doronbehar) and it doesn't build correctly with `buildLuarocksPackage` (see #89767).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From some reason, the package is not usable if it's built with
buildLuarocksPackage. AddingextraVariablesas inmakeFlagsdoesn't work. See:#89632 (comment)
Now it uses
buildLuaPackageas it used to.cc @teto. I really don't know why is that. If you could find something wrong with "upstream's" rockspec file or my Makefile, please tell me:
I only followed Luarocks' Wiki when I wrote these - https://github.com/luarocks/luarocks/wiki/Rockspec-format .
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)