Skip to content

MERGE Feature 1 user interface development#9

Merged
LiamKnapp merged 2 commits intoDevelopmentfrom
Feature_1_User_Interface_Development
Mar 21, 2025
Merged

MERGE Feature 1 user interface development#9
LiamKnapp merged 2 commits intoDevelopmentfrom
Feature_1_User_Interface_Development

Conversation

@LiamKnapp
Copy link
Copy Markdown
Collaborator

@LiamKnapp LiamKnapp commented Mar 21, 2025

CodeAnt-AI Description

  • Added macOS and iOS project configurations for the Flutter application, including build settings, file references, and shell scripts for build processes.
  • Implemented a new web client homepage with navigation, sections, and styling using Bootstrap and AOS.
  • Developed JavaScript functionalities for market prediction, including stock data management, user interactions, and chart creation.
  • Added Win32 window management for the Windows Flutter application, with DPI scaling and theme updates.
  • Configured macOS application interface with MainMenu.xib and application settings in Info.plist.

This PR introduces the initial setup for a cross-platform Flutter application, covering macOS, iOS, Windows, and web platforms. It establishes the necessary project configurations and user interface components, enhancing the application's structure and functionality.


Changes walkthrough

Relevant files
Enhancement
project.pbxproj
Add macOS Flutter project configuration and build settings         

src/UI/mobile_client/macos/Runner.xcodeproj/project.pbxproj

  • Added new build configurations and targets for macOS Flutter
    application.
  • Configured build phases and file references for macOS project.
  • Set up shell scripts for Flutter build processes.
  • +705/-0 
    project.pbxproj
    Add iOS Flutter project configuration and build settings             

    src/UI/mobile_client/ios/Runner.xcodeproj/project.pbxproj

  • Added iOS project configuration for Flutter application.
  • Configured build phases and file references for iOS project.
  • Set up shell scripts for iOS build processes.
  • +616/-0 
    MainMenu.xib
    Add macOS MainMenu.xib for application interface                             

    src/UI/mobile_client/macos/Runner/Base.lproj/MainMenu.xib

  • Added MainMenu.xib for macOS application interface.
  • Configured menu items and actions for macOS app.
  • +343/-0 
    index.html
    Add web client homepage with navigation and sections                     

    src/UI/web_client/index.html

  • Created a new index.html for the web client.
  • Set up navigation and sections for the web application.
  • Integrated Bootstrap and AOS for styling and animations.
  • +273/-0 
    marketPrediction.js
    Implement market prediction logic and UI interactions                   

    src/UI/web_client/js/marketPrediction.js

  • Implemented JavaScript for market prediction features.
  • Added functions to manage stock data and user interactions.
  • Integrated chart creation and news fetching functionalities.
  • +309/-0 
    win32_window.cpp
    Add Win32 window management for Windows Flutter app                       

    src/UI/mobile_client/windows/runner/win32_window.cpp

  • Added Win32 window management for Windows Flutter application.
  • Implemented DPI scaling and theme updates.
  • Set up message handling for window events.
  • +288/-0 
    Configuration changes
    Info.plist
    Add macOS Info.plist for application configuration                         

    src/UI/mobile_client/macos/Runner/Info.plist

  • Added Info.plist for macOS application configuration.
  • Defined bundle identifiers and versioning information.
  • +32/-0   
    💡 Usage Guide

    Checking Your Pull Request

    Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

    Talking to CodeAnt AI

    Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

    @codeant-ai ask: Your question here
    

    This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

    Retrigger review

    Ask CodeAnt AI to review the PR again, by typing:

    @codeant-ai: review
    

    Check Your Repository Health

    To analyze the health of your code repository, visit our dashboard at app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

    @LiamKnapp LiamKnapp linked an issue Mar 21, 2025 that may be closed by this pull request
    @codeant-ai codeant-ai bot added the size:XXL This PR changes 1000+ lines, ignoring generated files label Mar 21, 2025
    @codeant-ai
    Copy link
    Copy Markdown

    codeant-ai bot commented Mar 21, 2025

    Pull Request Feedback 🔍

    🔒 No security issues identified
    ⚡ Recommended areas for review

    Duplicate Function Definition
    The function resetCharts is defined twice (once around lines 71–83 and again around lines 106–118). This duplicate definition may lead to unexpected behavior. Consider consolidating them into a single definition.

    Inconsistent Login Logic
    In the isLoggedIn function, the code always returns true (lines 7–10) despite a comment implying the user is not logged in. Review this logic to ensure it aligns with the intended authentication flow.

    Multiple DOMContentLoaded Listeners
    The file registers several DOMContentLoaded event listeners in different parts of the code (e.g., at lines 1–26, 28–136, and later). Consolidating them into a single event listener may improve readability and maintainability.

    GCC_WARN_UNDECLARED_SELECTOR = YES
    CLANG_UNDEFINED_BEHAVIOR_SANITIZER_NULLABILITY = YES
    CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE
    CLANG_WARN__DUPLICATE_METHOD_MATCH = YES
    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggestion: Correct the extra underscore in the warning flag to match the standard flag name. [possible bug]

    Suggested change
    CLANG_WARN__DUPLICATE_METHOD_MATCH = YES
    CLANG_WARN_DUPLICATE_METHOD_MATCH = YES

    @LiamKnapp LiamKnapp merged commit 3e2335d into Development Mar 21, 2025
    1 of 2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    size:XXL This PR changes 1000+ lines, ignoring generated files

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Feature 1: User Interface Development

    2 participants