Skip to content

Apply changes from PR #330 excluding getting-started files #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copilot wants to merge 3 commits into from
Closed

Apply changes from PR #330 excluding getting-started files #334

Copilot wants to merge 3 commits into from

Conversation

Copy link

Copilot AI commented Nov 28, 2025 •
edited
Loading

  • Fetch PR Add "Getting started guide" and Headless Overview #330 branch
  • Apply changes from PR Add "Getting started guide" and Headless Overview #330, excluding all files with "getting-started" in path
  • Modify SUMMARY.md to include only non-getting-started changes
  • Address review feedback:
    • SUMMARY.md: Revert structure to keep "Introduction" at top level
    • SUMMARY.md: Change "Manual Tagging" to "Manual Implementation"
    • Remove "reach out" sentence from customer group pricing docs
    • Fix typo: "changed" to "changes" in customer group pricing docs
    • Update manual implementation README title
    • Remove Prerequisites section from PSN implementation guide
Original prompt

This section details on the original issue you should resolve

<issue_title>split PR</issue_title>
<issue_description>create a new single commit PR based on https://github.com/Nosto/wiki-docs/pull/330/files
skip all files with getting-started in the path</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 28, 2025
Copilot AI requested a review from timowestnosto November 28, 2025 07:03
@timowestnosto
Copy link

timowestnosto commented Nov 28, 2025

@copilot try again

@timowestnosto
Copy link

timowestnosto commented Nov 28, 2025

@copilot try again

@timowestnosto
Copy link

timowestnosto commented Nov 28, 2025

@copilot try again

@timowestnosto
Apply changes from PR #330 excluding getting-started files
2001f3b 
Co-authored-by: timowestnosto <13622115+timowestnosto@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 28, 2025

@copilot try again

I've successfully created a new single commit based on PR #330, excluding all files with "getting-started" in the path. The commit includes:

  • 2 video assets from .gitbook/assets/
  • Updates to SUMMARY.md (restructured, added PSN section, excluded getting-started section)
  • Updates to Session API documentation files
  • Updates to advanced implementation files (customer group pricing, parameterless attribution)
  • New Personalized Campaign Widgets implementation guide
  • Updates to manual implementation README

All getting-started files have been excluded as requested.

Commit: 2001f3b

Copilot AI changed the title [WIP] Create a new single commit PR based on previous changes Apply changes from PR #330 excluding getting-started files Nov 28, 2025
Copilot finished work on behalf of timowestnosto November 28, 2025 12:57
timowestnosto
timowestnosto requested changes Nov 28, 2025
View reviewed changes
Copy link

@timowestnosto timowestnosto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot fix these

SUMMARY.md Outdated
* [Introduction](README.md)
* [Implement on your website](implementing-nosto/implement-on-your-website/README.md)
* [Manual Implementation - Essentials](implementing-nosto/implement-on-your-website/manual-implementation/README.md)
* [Manual Tagging - Essentials](implementing-nosto/implement-on-your-website/manual-implementation/README.md)
Copy link

@timowestnosto timowestnosto Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging -> Implementation

Copy link
Author

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 091d499

SUMMARY.md Outdated

## Implementing Nosto

* [Introduction](README.md)
Copy link

@timowestnosto timowestnosto Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this line

Copy link
Author

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 091d499

SUMMARY.md
@@ -1,11 +1,10 @@
# Table of contents

* [Introduction](README.md)
Copy link

@timowestnosto timowestnosto Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change

Copy link
Author

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 091d499

...plement-on-your-website/advanced-implementation/adding-support-for-customer-group-pricing.md Outdated
## Edge cases

**Note:** You cannot use SKUs with this feature at the time of writing.
If either of the following cases applies to you, we recommend either an API implementation or fetching the prices via an frontend API (instead of sending the price variations to Nosto). Please [reach out to our team](mailto:onboarding@nosto.com) or your Nosto onboarding manager for additional consultation.
Copy link

@timowestnosto timowestnosto Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop "Please reach out to our team or your Nosto onboarding manager for additional consultation."

Copy link
Author

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 091d499

...plement-on-your-website/advanced-implementation/adding-support-for-customer-group-pricing.md Outdated
## Enabling multi-variants from the admin

Once the tagging changes have been done and the API implemented, you need to configure and enable it from your admin panel under **Settings** > **Other** > **Multi-Currency**. Toggle the **Use Multiple Currencies** switch on and **Use Exchange Rates** switch off and set the variation ID of the primary currency via the input field and toggle on the exchange rates switch.
Once the tagging changed have been done and the API implemented, you need to configure and enable it from your admin panel under **Settings** > **Other** > **Multi-Currency**. Toggle the **Use Multiple Currencies** switch on and **Use Exchange Rates** switch off and set the variation ID of the primary currency via the input field and toggle on the exchange rates switch.
Copy link

@timowestnosto timowestnosto Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed -> changes

Copy link
Author

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 091d499

implementing-nosto/implement-on-your-website/manual-implementation/README.md Outdated
@@ -1,8 +1,10 @@
# Manual Implementation - Essentials
# Manual Tagging - Essentials
Copy link

@timowestnosto timowestnosto Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging -> Implementation

Copy link
Author

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 091d499

implementing-nosto/implement-psn/README.md Outdated

If you only have a complex product card but are using a Shopify theme, you can consider using our [dynamic product cards](../../implementing-nosto/template-customization/product-cards.md)

## Prerequisites
Copy link

@timowestnosto timowestnosto Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this section

Copy link
Author

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 091d499

@timowestnosto
Address review feedback: fix SUMMARY.md structure, update terminology…
091d499 
…, and remove Prerequisites section

Co-authored-by: timowestnosto <13622115+timowestnosto@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 28, 2025

@copilot fix these

Fixed all review comments in commit 091d499:

  • Reverted SUMMARY.md structure to keep "Introduction" at top level
  • Changed "Manual Tagging" to "Manual Implementation" throughout
  • Removed "reach out" sentence from customer group pricing docs
  • Fixed typo: "changed" → "changes"
  • Removed Prerequisites section from PSN implementation guide

Copilot AI requested a review from timowestnosto November 28, 2025 13:04
Copilot finished work on behalf of timowestnosto November 28, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timowestnosto timowestnosto Awaiting requested review from timowestnosto

Assignees

@timowestnosto timowestnosto

Copilot code review Copilot

Labels

WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timowestnosto