fix(gateway): fall back to module entrypoint when hermes is not on PATH#1150
Closed
eren-karakus0 wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(gateway): fall back to module entrypoint when hermes is not on PATH#1150eren-karakus0 wants to merge 1 commit intoNousResearch:mainfrom
eren-karakus0 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
/update hard-failed with "command not found on PATH" even when Hermes was already running via venv/pipx/module-based installs. Now falls back to `sys.executable -m hermes_cli.main` instead of returning an error. Fixes NousResearch#1049
Contributor
|
duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/updatehard-failed with✗ hermes command not found on PATHeven when Hermes was already running. This happens in venv, pipx, or module-based installs where thehermesexecutable is not on the gateway process's PATH.Now falls back to
sys.executable -m hermes_cli.maininstead of returning an error.Changes
gateway/run.py: Replace hard-fail with fallback to{sys.executable} -m hermes_cli.mainwhenshutil.which("hermes")returnsNonetests/gateway/test_update_command.py: Update existing test to verify fallback behavior — checks that the update proceeds and the command string contains the module entrypointTest plan
hermesnot on PATH → falls back to module entrypoint, update proceedshermeson PATH → existing behavior unchanged (uses binary directly)Fixes #1049