feat(skills): add optional backend probing and command checks#1159
Closed
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Closed
feat(skills): add optional backend probing and command checks#1159kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
kshitijk4poor wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Contributor
|
Closing — the underlying problem this aimed to solve (skill prerequisites not being available in remote backends) has been addressed by credential file passthrough (#3671) and env var passthrough, which ensure secrets and environment variables are forwarded to docker/ssh/modal/etc at execution time rather than probing for their presence after the fact. The shared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1153 / original stacked follow-up from #723.
This finishes the remaining skill-readiness work by making prerequisite detection backend-aware.
Before this PR, skill readiness only reflected the current Python process and persisted local env state. That produced false
setup_neededresults in two important cases:This PR adds shared probing helpers so skill readiness can report what is actually available in the environment where the skill will run.
What Changed
Skill prerequisite probing
skill_view()can detect prerequisites available through the user's real shell environmentrequired_commandsmissing_required_commandssetup_neededreflect both missing env vars and missing commandsTerminal / runtime plumbing
get_or_create_environment()so backend-aware helpers can reuse the same runtime boundary as terminal executionworkdiris passedShared runtime surface checks
tools/runtime.pywith a sharedis_gateway_surface()helperTests
Why This Matters
This makes skill readiness much closer to the environment that will actually execute the skill:
In practice this should reduce false-positive setup prompts and make skill readiness metadata much easier to trust.
Test Results
source .venv/bin/activate && python -m pytest tests/tools/test_skills_tool.py tests/tools/test_terminal_tool.py tests/agent/test_prompt_builder.py -qsource .venv/bin/activate && python -m pytest tests/agent/test_skill_commands.py tests/test_run_agent.py tests/tools/test_registry.py -qFollow-up to #688.