Closed
Conversation
…d config to facilitate local dev
…hat the Tool Gateway stuff is for Nous Subscribers
- Added support for managed FAL gateway in image generation tool, allowing fallback when direct credentials are absent. - Enhanced transcription tools to utilize managed OpenAI audio gateway when direct API key is missing. - Updated TTS tool to use managed audio gateway for OpenAI when direct credentials are absent. - Introduced ManagedModalEnvironment for modal execution, preferring managed mode when direct credentials are not available. - Refactored web tools to utilize a generic managed tool gateway for vendor passthroughs. - Added utility functions for resolving managed tool gateway configurations and checking their readiness.
Contributor
Author
|
Closing PR for now - we'll merge this when we have this working for multiple providers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a Nous Subscriber tool-gateway path for the web tools while preserving direct Firecrawl configuration as the explicit override. It also hardens the web tooling stack by normalizing Firecrawl SDK/gateway response shapes, re-resolving auxiliary summarization clients and models at call time instead of relying on stale import-time state, and exposing Nous login URL/TLS overrides through
hermes modelfor local and staging workflows.This approach keeps existing direct Firecrawl users on the same path, lets subscriber-authenticated users access web tools without separate Firecrawl setup, and makes local development/testing easier without special-case code changes.
Related Issue
n/a
Type of Change
Changes Made
tools/web_tools.py, including support forFIRECRAWL_GATEWAY_URL,TOOL_GATEWAY_DOMAIN,TOOL_GATEWAY_SCHEME, andTOOL_GATEWAY_USER_TOKEN, with direct Firecrawl config still taking precedence.tools/web_tools.pyto normalize search/scrape/crawl payloads across Firecrawl response shapes and to re-resolve auxiliary clients/models for web extract summaries so late-available backends are picked up correctly.hermes_cli/main.pyandhermes_cli/config.py, including forwarding portal URL, inference URL, client ID, scope, browser, timeout, CA bundle, and TLS verification flags throughhermes model..env.example,README.md,website/docs/reference/environment-variables.md, andAGENTS.md.tests/tools/test_web_tools_config.pyandtests/test_cli_provider_resolution.py, and addeddebugpyto dev dependencies inpyproject.tomlandrequirements.txt.How to Test
source venv/bin/activatepython -m pytest tests/tools/test_web_tools_config.py -qandpython -m pytest tests/test_cli_provider_resolution.py::test_cmd_model_forwards_nous_login_tls_options -qhermes modeland select Nous Research SubscriptionFIRECRAWL_API_KEYis not set anywhere in your envChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — N/A (noconfig.yamlkeys changed)CONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows —AGENTS.mdupdatedScreenshots / Logs
python -m pytest tests/tools/test_web_tools_config.py -q→17 passed in 2.80spython -m pytest tests/test_cli_provider_resolution.py::test_cmd_model_forwards_nous_login_tls_options -q→1 passed in 1.59spython -m pytest tests/ -q→3456 passed, 162 skipped, 5 failed in 29.44stests/test_quick_commands.py::TestCLIQuickCommands::test_exec_command_runs_and_prints_outputtests/test_quick_commands.py::TestCLIQuickCommands::test_quick_command_takes_priority_over_skill_commandstests/test_managed_server_tool_support.py::TestBaseEnvCompatibility::test_hermes_base_env_managed_server_call_patterntests/test_managed_server_tool_support.py::TestBaseEnvCompatibility::test_hermes_base_env_uses_get_parsertests/test_cli_provider_resolution.py::test_codex_provider_uses_config_model