fix(gateway): fix dictionary iteration race condition during stop#1195
Closed
usvimal wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(gateway): fix dictionary iteration race condition during stop#1195usvimal wants to merge 1 commit intoNousResearch:mainfrom
usvimal wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The stop() method iterates over self.adapters.items() while another async task could be modifying the dict. Copy the dict before iterating to avoid RuntimeError: dictionary changed size during iteration. Fixes race condition that occurred during gateway shutdown.
usvimal
force-pushed
the
fix/gateway-race-condition
branch
from
ffdb9bf to
3350714
Compare
Contributor
|
Thanks for the PR. I'm closing this as redundant because the shutdown fix is already present on current
So the Appreciate the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The method iterates over while another async task could be modifying the dict, causing:
Solution
Copy the dict before iterating using .
Changes
This is a minimal, safe fix that prevents the race condition during gateway shutdown.