fix(telegram): check updater/app state before disconnect#1197
Closed
usvimal wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(telegram): check updater/app state before disconnect#1197usvimal wants to merge 1 commit intoNousResearch:mainfrom
usvimal wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The disconnect() method was unconditionally calling updater.stop() and app.stop(), causing errors when: - The updater was not running (RuntimeError: This Updater is not running!) - The app was None (AttributeError: 'NoneType' object has no attribute) Changes: - Check if updater exists and is running before stopping - Check if app is running before stopping - Only log warnings for actual errors, not expected shutdown states Fixes spurious warnings during gateway shutdown.
usvimal
force-pushed
the
fix/telegram-disconnect-error-handling
branch
from
19a1956 to
81a4940
Compare
Contributor
|
Merged via PR #1389. Your substantive fix was cherry-picked onto current main with authorship preserved, and I added a regression test on top. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The method unconditionally called and , causing spurious errors during gateway shutdown:
These errors were caught and logged as warnings, but they represent expected states during shutdown, not actual problems.
Solution
Check if the updater and app are actually running before attempting to stop them.
Changes
This eliminates noise in the logs during graceful shutdown.