Improve Firecrawl configuration error message and add logging#1763
Closed
JackTheGit wants to merge 2 commits intoNousResearch:mainfrom
Closed
Improve Firecrawl configuration error message and add logging#1763JackTheGit wants to merge 2 commits intoNousResearch:mainfrom
JackTheGit wants to merge 2 commits intoNousResearch:mainfrom
Conversation
Contributor
|
Merged via PR #2341 — both commits cherry-picked with authorship preserved. Good catch on the whitespace edge case. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves robustness and error handling in
tools/web_tools.py.Previously, values like " " were treated as valid configuration,
leading to incorrect backend selection.
The updated error message explicitly indicates that either
FIRECRAWL_API_KEY(cloud) orFIRECRAWL_API_URL(self-hosted) must be set.No breaking changes.