Remove LR scheduler for workers#1002
Open
jonahsamost wants to merge 3 commits intoNovaSky-AI:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively removes the internal learning rate scheduler logic from the training workers, centralizing LR control under an external system like Tinker. The changes are consistent and thorough across FSDP and Megatron strategies, abstract base classes, and worker implementations. Key modifications include removing scheduler instantiation, step() calls, and state management from checkpoints. The code is now cleaner and the responsibility for learning rate scheduling is clearly externalized. The changes look solid.
Comment on lines
21
to
24
| from skyrl_train.distributed.megatron.optimizer import ( | ||
| init_megatron_optim_config, | ||
| get_megatron_optimizer, | ||
| get_megatron_optimizer_param_scheduler, | ||
| ) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing #998
Remove internal learning rate scheduler logic from the skyRL train workers.
Since #978 added set_lr() support, Tinker can now control the LR externally. Since the workers's LRs could conflict with Tinker's LR, we just remove the ability for workers to set their own LRs