[Harbor] Add Modal support and bump Harbor version#1022
Merged
CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom Feb 4, 2026
Merged
[Harbor] Add Modal support and bump Harbor version#1022CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom
CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request bumps the Harbor version and adds support for Modal by passing environment variables for authentication. The changes are consistent across the pyproject.toml, lock file, and documentation. I've provided a suggestion to refactor the new environment variable handling logic in skyrl_train/utils/utils.py to improve maintainability. I've also suggested some minor improvements to the README.md for clarity and to remove a placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We bump Harbor version (commit hash) so configs added here can be picked up #987
We also add Modal support (mainly environment key passing, which we should get a more sustainable solution and document that).