[tx] Implement cutlass kernel for ragged_dot with group_offset#896
Open
pcmoritz wants to merge 108 commits intoNovaSky-AI:mainfrom
Open
[tx] Implement cutlass kernel for ragged_dot with group_offset#896pcmoritz wants to merge 108 commits intoNovaSky-AI:mainfrom
pcmoritz wants to merge 108 commits intoNovaSky-AI:mainfrom
Conversation
…o tx-ragged-dot-cutlass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings down the step time of
with
from 40s to 20s. I spend some time tuning the tile sizes and also tried different tile sizes / configurations for different settings (e.g. the different projections or low k setting for LoRA), but it only made a very small difference and wouldn't be worth the complexity for now.