[skyrl-train] Add GDPO Support to PPO Utils#897
Open
devpatelio wants to merge 2 commits intoNovaSky-AI:mainfrom
Open
[skyrl-train] Add GDPO Support to PPO Utils#897devpatelio wants to merge 2 commits intoNovaSky-AI:mainfrom
devpatelio wants to merge 2 commits intoNovaSky-AI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Group-wise Distributional Policy Optimization (GDPO) advantage estimation by adding a new advantage estimator, compute_gdpo_outcome_advantage, to the PPO utilities. A medium-severity vulnerability was identified in the new GDPO implementation, specifically a critical bug in the group-wise normalization step that could lead to division by zero. Additionally, a broken link to the reference paper in the docstring was found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDPO is an extension of GRPO for multi-reward settings where we do group-wise normalization of each reward function prior to computing the advantage. This is then followed by a batch-norm across all prompts belonging to a given batch and it's respective advantages (
GDPO Paper)Points of clarification:
TODOs: