Skip to content

Fix issue with null system prompt after #104 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SumanthRH merged 2 commits into from
Apr 17, 2025
Merged

Fix issue with null system prompt after #104 #107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7426cd
x
SumanthRH Apr 17, 2025
49e590d
x
SumanthRH Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skythought/evals/inference_and_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def generate_responses_for_dataset(
# Prepare conversations
conversations = handler.make_conversations(
remaining_data,
str(model_config.system_prompt),
str(model_config.system_prompt) if model_config.system_prompt else None,
model_config.user_template,
model_config.assistant_prefill,
)
Expand Down