[Evals] 1/N Add more task related tests#110
Merged
Conversation
Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
yllkryeziu
pushed a commit
to yllkryeziu/adaptive-compute-rewrite
that referenced
this pull request
Dec 12, 2025
# What does this PR do? Adds more task specific tests. The tests are pretty lightweight and basic. The idea is to be able to catch any errors in templating and having basic E2E correctness checks for each task to avoid issues like NovaSky-AI#108 There is some repetition across tests which is intentional: It's best to decouple tests for different tasks. I'll add more tests for other tasks in future PRs. --------- Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds more task specific tests. The tests are pretty lightweight and basic. The idea is to be able to catch any errors in templating and having basic E2E correctness checks for each task to avoid issues like #108
There is some repetition across tests which is intentional: It's best to decouple tests for different tasks.
I'll add more tests for other tasks in future PRs.