RFC: source & sink: fix get_freq_corr() calling wrong function#19
Open
MrCry0 wants to merge 1 commit intoNuand:mainfrom
Open
RFC: source & sink: fix get_freq_corr() calling wrong function#19MrCry0 wants to merge 1 commit intoNuand:mainfrom
MrCry0 wants to merge 1 commit intoNuand:mainfrom
Conversation
Both source_impl and sink_impl::get_freq_corr() were delegating to get_center_freq() instead of get_freq_corr(), causing callers to receive the tuned centre frequency (Hz) instead of the PPM correction value. Signed-off-by: Oleksandr Suvorov <cryosay@gmail.com>
MrCry0
force-pushed
the
fix/get-corr-freq
branch
from
eba9284 to
40a3f31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure, may be I don't see something important, but it look like we call wrong get functions for correction.
Both source_impl and sink_impl::get_freq_corr() were delegating to get_center_freq() instead of get_freq_corr(), causing callers to receive the tuned centre frequency (Hz) instead of the PPM correction value.