grc: fix out_clk options using bare YAML booleans instead of strings#22
Open
MrCry0 wants to merge 1 commit intoNuand:mainfrom
Open
grc: fix out_clk options using bare YAML booleans instead of strings#22MrCry0 wants to merge 1 commit intoNuand:mainfrom
MrCry0 wants to merge 1 commit intoNuand:mainfrom
Conversation
The out_clk parameter used unquoted False/True, which YAML parses as booleans rather than the string values every other enum parameter uses. Quote them to be consistent with the rest of the block definition. Signed-off-by: Oleksandr Suvorov <cryosay@gmail.com>
MrCry0
force-pushed
the
fix/output-clock
branch
from
458d513 to
f4ea579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The out_clk parameter used unquoted False/True, which YAML parses as booleans rather than the string values every other enum parameter uses. Quote them to be consistent with the rest of the block definition.