Skip to content

Conversation

@BhaveshHeliconia
Copy link

No description provided.

@pedrobaeza
Copy link
Member

/ocabot migration calendar_event_link_base

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 3, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 3, 2025
5 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-calendar_event_link_base branch from bb37c60 to 732465b Compare April 1, 2025 06:23
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name_get method does not exist anymore since v18

context = {
"default_res_id": self.id,
"default_res_model": self._name,
"default_name": self.name_get()[0][1],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"default_name": self.name_get()[0][1],
"default_name": self.display_name,

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-calendar_event_link_base branch from 732465b to e7f1af3 Compare May 2, 2025 04:40
@BhaveshHeliconia
Copy link
Author

@cvinh, Please Review.

@BhaveshHeliconia BhaveshHeliconia requested a review from cvinh May 2, 2025 12:04
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 31, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-calendar_event_link_base branch from e7f1af3 to bf9cca7 Compare September 1, 2025 06:19
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 7, 2025
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants