18.0 [FIX][IMP] calendar_import_ics: fix date parsing, add attendees by email #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three things:
"Z"at the end of theDTSTARTandDTEND. This would just crash the whole importThe third point is a bit iffy regarding current functionality; before, you can import the whole file, and if you reimport it with an empty date range, it would remove all imported events. If you imported other attendees, the unlink won't run. Since we have the exact event
uid, we could add another boolean control. I'm not sure what is the exact use case for this feature, so I'm not sure what would be the best course of action on that.