Skip to content

Conversation

@huguesdk
Copy link
Member

move cooperator_website_recaptcha module from coopiteasy/vertical-cooperative to the oca (and migrate it to 16.0).

this is the 16.0 version of #44.

tests will fail until OCA/website#1032 is merged.

carmenbianca and others added 16 commits January 15, 2024 17:39
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
* move the recaptcha widget view to portal_recaptcha.
* remove res.company.captcha_type (portal_recaptcha can now be enabled
  and disabled in the settings).
* override WebsiteSubscription._additional_validate() instead of
  .validation().
fix author and website manifest properties to follow oca's guidelines.
use website_recaptcha_v2 instead of portal_recaptcha.
Copy link

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successful functional test

@dreispt
Copy link
Member

dreispt commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-110-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 2, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-110-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@huguesdk
Copy link
Member Author

huguesdk commented May 3, 2024

@dreispt thanks for taking time for this. this pr is ready, but it depends on OCA/website#1032, which should be merged first. could you help with that?

@github-actions
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@huguesdk huguesdk added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. needs fixing labels Sep 2, 2024
@legalsylvain
Copy link

Hi all. This one can be merged. CC : @huguesdk

@huguesdk
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-110-by-huguesdk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 28, 2025
Signed-off-by huguesdk
@OCA-git-bot
Copy link
Contributor

@huguesdk your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-110-by-huguesdk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@huguesdk
Copy link
Member Author

huguesdk commented May 28, 2025

@legalsylvain indeed, thanks for the heads up! it seems like there is a problem with the tests that prevents the merge. i’m going to look into it.

@huguesdk
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-110-by-huguesdk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f09a817 into OCA:16.0 May 30, 2025
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6e2409b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved help wanted merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants