[16.0][REF] cooperator: moving from legal_form to partner_company_type #167

mihien · 2025-09-28T16:57:28Z

The current legal_form field that represents the company types is currently hard coded in each localization module and can not be modified by the user to add or remove a value.

Replacing this value by the OCA module partner_company_type, makes this field more generic. Simplifying localization which now requires just either a module data or can be added directly from the user interface.

edit (by @huguesdk): this depends on:

huguesdk

mostly lgtm, thanks for this, @mihien!

small but important problem: after filling the /become_company_cooperator form, the selected company type is not set on the subscription request. for this to work, you need to modify cooperator_website/views/subscription_template.xml and replace any occurence of company_type by partner_company_type_id.

huguesdk · 2025-09-29T15:13:50Z

cooperator/tests/test_cooperator.py

        # an existing type cannot be used because they are only defined in
        # localization modules.


this comment should be removed.

huguesdk · 2025-09-29T15:15:39Z

l10n_be_cooperator/__manifest__.py

    "name": "Cooperators Belgium",
    "summary": "Cooperators Belgium Localization",
-    "version": "16.0.1.2.1",
+    "version": "16.0.3.0.0",


Suggested change

"version": "16.0.3.0.0",

"version": "16.0.2.0.0",

huguesdk · 2025-09-29T15:16:00Z

l10n_be_cooperator/migrations/16.0.3.0.0/post-legal_form.py

+
+
+def migrate(cr, version):
+


Suggested change

there shouldn’t be a blank line here.

huguesdk · 2025-09-29T15:20:32Z

l10n_be_cooperator/migrations/16.0.3.0.0/post-legal_form.py

+    # module. We're using the fact that the label of the legal_form selection
+    # field is the same as the ids of the records in l10n_be_company_types.


Suggested change

# module. We're using the fact that the label of the legal_form selection

# field is the same as the ids of the records in l10n_be_company_types.

# module. We're using the fact that the values of the legal_form selection

# field are the same as the xml ids of the records in l10n_be_partner_company_type.

huguesdk · 2025-09-29T15:20:45Z

l10n_be_cooperator/migrations/16.0.3.0.0/pre-legal_form.py

+
+
+def migrate(cr, version):
+


Suggested change

huguesdk · 2025-09-29T15:21:35Z

l10n_be_cooperator/migrations/16.0.3.0.0/pre-legal_form.py

+    # Remove the old values in res_partner.legal_form to prepare the database for
+    # those fields to be deleted. Otherwise the values added by add_selection
+    # will not be valid anymore but would still be present in the db.
+    cr.execute(
+        """
+        UPDATE res_partner
+        SET legal_form = NULL
+        """
+    )
+


is this needed? the column will be deleted no matter what. same remark for subscription_request.company_type.

huguesdk · 2025-09-29T15:29:55Z

cooperator_website/controllers/main.py

+        company_types_records = (
+            request.env["res.partner.company.type"].sudo().search([])
+        )
+        company_types = [(record.id, record.name) for record in company_types_records]


i think it would be a good addition to also display the abbreviation next to the name:

Suggested change

company_types = [(record.id, record.name) for record in company_types_records]

company_types = [

(

record.id,

"{name} ({abbr})".format(name=record.name, abbr=record.shortcut),

)

for record in company_types_records

]

actually, i’m not so sure about this. maybe this should be changed directly in the partner_company_type module (for example, having a “display name” field), to ensure consistency (also in the internal partner forms, for example).

huguesdk · 2025-09-29T15:48:53Z

cooperator_website/controllers/main.py

                values["company_name"] = partner.name
                values["company_email"] = partner.email
-                values["company_type"] = partner.legal_form
+                values["partner_company_type_id"] = partner.partner_company_type_id


Suggested change

values["partner_company_type_id"] = partner.partner_company_type_id

values["partner_company_type_id"] = partner.partner_company_type_id.id

huguesdk · 2025-09-29T15:51:32Z

cooperator_website/controllers/main.py

        values["products"] = products
-        fields_desc = sub_req_obj.sudo().fields_get(["company_type", "gender"])
-        values["company_types"] = fields_desc["company_type"]["selection"]
+        values["company_types"] = self.get_company_types()


Suggested change

values["company_types"] = self.get_company_types()

values["partner_company_type_ids"] = self.get_company_types()

huguesdk

just a few things to clean up, but apart from that, lgtm. thanks for this important (and tricky) improvement, @mihien!

huguesdk · 2025-11-10T08:47:50Z

cooperator_website/controllers/main.py

        if not values.get("activities_country_id"):
            if company.default_country_id:
                values["activities_country_id"] = company.default_country_id.id
            else:
-                values["activities_country_id"] = "20"
+                values["activities_country_id"] = 20


this part is obsolete (i didn’t know about this field and it is used nowhere anymore) and can be removed.

cooperator/static/description/index.html

cooperator/README.rst

cooperator_website/README.rst

cooperator_website/static/description/index.html

huguesdk

i did the finishing touches myself so we can deploy. i added your changes to l10n_ch_cooperator here (after merging #146) and added a migration script.

i changed my mind about changes in readme files: pre-commit generates these changes anyway, so logically they should be added. but we need to ensure that the maintainer-tools repo used locally by pre-commit is up to date (and used with a recent python version), otherwise it could introduce changes that would be reverted after the merge.

* adapt subscription form to changes in cooperator_website. * fix layout of bank account number and vat fields.

mihien force-pushed the 16.0-ref-cooperator-company_type branch from bf495c1 to 36ec27f Compare September 28, 2025 17:16

huguesdk requested changes Sep 29, 2025

View reviewed changes

mihien force-pushed the 16.0-ref-cooperator-company_type branch 2 times, most recently from 3648c66 to ed5e7be Compare October 7, 2025 15:07

mihien force-pushed the 16.0-ref-cooperator-company_type branch 2 times, most recently from 20351b0 to b582938 Compare November 7, 2025 03:16

huguesdk requested changes Nov 10, 2025

View reviewed changes

huguesdk force-pushed the 16.0-ref-cooperator-company_type branch 2 times, most recently from 6dce7b0 to 70d41dc Compare November 10, 2025 16:26

huguesdk approved these changes Nov 10, 2025

View reviewed changes

huguesdk force-pushed the 16.0-ref-cooperator-company_type branch from 70d41dc to 818bb8a Compare November 10, 2025 19:33

huguesdk mentioned this pull request Nov 11, 2025

[16.0][MIG] l10n_ch_cooperator: migration to 16.0 #146

Merged

mihien and others added 7 commits December 15, 2025 17:49

[REF] cooperator: replace legal_form by partner_company_type

1012780

[REF] cooperator_website: replace legal_form by partner_company_type

506a722

[REF] l10n_be_cooperator: replace legal_form by partner_company_type

ac73803

[REF] l10n_fr_cooperator: replace legal_form by partner_company_type

5bcddf0

[REF] l10n_de_cooperator: replace legal_form by partner_company_type

15bf0b8

[REF] l10n_ch_cooperator: replace legal_form by partner_company_type

e8ab0b4

[IMP] fix and improve layout of subscription form

11afe6a

* adapt subscription form to changes in cooperator_website. * fix layout of bank account number and vat fields.

remytms force-pushed the 16.0-ref-cooperator-company_type branch from 818bb8a to 11afe6a Compare December 15, 2025 16:50

		# an existing type cannot be used because they are only defined in
		# localization modules.

		# module. We're using the fact that the label of the legal_form selection
		# field is the same as the ids of the records in l10n_be_company_types.

	values["partner_company_type_id"] = partner.partner_company_type_id
	values["partner_company_type_id"] = partner.partner_company_type_id.id

	values["company_types"] = self.get_company_types()
	values["partner_company_type_ids"] = self.get_company_types()

Uh oh!

[16.0][REF] cooperator: moving from legal_form to partner_company_type #167

Are you sure you want to change the base?

[16.0][REF] cooperator: moving from legal_form to partner_company_type #167

Uh oh!

Conversation

mihien commented Sep 28, 2025 • edited by huguesdk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huguesdk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huguesdk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huguesdk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mihien commented Sep 28, 2025 •

edited by huguesdk

Loading

huguesdk left a comment •

edited

Loading